rust: use clang-cl or cl as linkers for -msvc targets #15487
Merged
+64
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnicolodi
reviewed
Jan 20, 2026
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
With clang exists in the system path and cl does not, meson generates build.ninja file using clang as linker even for -msvc targets. Look at the target, detect the correct C/C++ compiler based on whether it is a MSVC target, and then use cc.linker as the linker for Rust. Fixes: mesonbuild#6638 Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
dcbaker
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With clang exists in the system path and cl does not, meson generates build.ninja file using clang as linker even for -msvc targets. Look at the target, and detect the correct C/C++ compiler based on whether it is a MSVC target.
Fixes: #6638